NaxdyOrg/NaxGCC-FW
2
0
Fork 2
Code Issues Pull requests 1 Releases 4 Activity Actions

add mode to further improve input latency while maintaining accuracy #8

Merged
Naxdy merged 7 commits from work/superhack-input-mode into main 2024-04-08 20:53:24 +00:00
Conversation 0 Commits 7 Files changed 5 +117 -63
Naxdy commented 2024-04-04 16:54:19 +00:00
Owner
Copy link

This feels even hackier than consistency mode... we hold off on writing USB reports until the button state actually changes. Passes the input integrity benchmark with ~99.6%, but that doesn't mean much since the challenge is preserving input integrity for inputs less than 8.33ms apart.

Current rate limiter looks good from initial measurements, so will probably merge this at some point and leave it up to users to try the mode out or not. For now, I'd still recommend regular consistency mode, it's still hacky, but way less than this.

Also, not breaking because the new enum for input consistency mode is backward compatible with the bool.

This feels even hackier than consistency mode... we hold off on writing USB reports until the button state actually changes. Passes the input integrity benchmark with ~99.6%, but that doesn't mean much since the challenge is preserving input integrity for inputs less than 8.33ms apart. Current rate limiter looks good from initial measurements, so will probably merge this at some point and leave it up to users to try the mode out or not. For now, I'd still recommend regular consistency mode, it's still hacky, but way less than this. Also, not breaking because the new enum for input consistency mode is backward compatible with the bool.
feat(hid): improve rate limiting in SuperHack mode
Some checks failed
Code quality / check (pull_request) Failing after 2m4s
Details
7f675c895d
Naxdy force-pushed work/superhack-input-mode from 7f675c895d to e9d37961b0 2024-04-05 10:21:59 +00:00 Compare
Naxdy force-pushed work/superhack-input-mode from e9d37961b0 to 0c53e49a50 2024-04-05 10:41:28 +00:00 Compare
Naxdy force-pushed work/superhack-input-mode from 0c53e49a50 to 7f675c895d 2024-04-05 11:01:29 +00:00 Compare
Naxdy force-pushed work/superhack-input-mode from 7f675c895d to db7391f9d3 2024-04-05 11:01:42 +00:00 Compare
fix clippy
All checks were successful
Code quality / check (pull_request) Successful in 1m36s
Details
8681239ef5
Naxdy changed title from WIP: add mode to further improve input latency while maintaining accuracy to add mode to further improve input latency while maintaining accuracy 2024-04-05 11:06:12 +00:00
chore: clarify super hack
All checks were successful
Code quality / check (pull_request) Successful in 1m42s
Details
96e280694b
Naxdy force-pushed work/superhack-input-mode from 96e280694b to 25b8986a1f 2024-04-05 11:52:35 +00:00 Compare
Naxdy changed title from add mode to further improve input latency while maintaining accuracy to WIP: add mode to further improve input latency while maintaining accuracy 2024-04-05 21:42:12 +00:00
Naxdy changed title from WIP: add mode to further improve input latency while maintaining accuracy to add mode to further improve input latency while maintaining accuracy 2024-04-08 20:37:46 +00:00
Naxdy force-pushed work/superhack-input-mode from 25b8986a1f to c27ac35d5e 2024-04-08 20:38:03 +00:00 Compare
Naxdy force-pushed work/superhack-input-mode from c27ac35d5e to 61e7d9f864 2024-04-08 20:38:32 +00:00 Compare
fix: disable input integrity benchmark by default
Some checks failed
Code quality / check (pull_request) Has been cancelled
Details
16ecb70f35
Naxdy force-pushed work/superhack-input-mode from 16ecb70f35 to 3dac2639a6 2024-04-08 20:40:58 +00:00 Compare
chore(main): remove unused import
All checks were successful
Code quality / check (pull_request) Successful in 1m35s
Details
fe8d358d56
Naxdy force-pushed work/superhack-input-mode from fe8d358d56 to 36d8c42d50 2024-04-08 20:47:15 +00:00 Compare
chore: clippy concurrency
Some checks failed
Code quality / check (pull_request) Has been cancelled
Details
e444cffeb6
Naxdy force-pushed work/superhack-input-mode from e444cffeb6 to f4b896ec29 2024-04-08 20:48:59 +00:00 Compare
Naxdy force-pushed work/superhack-input-mode from f4b896ec29 to 334022ed98 2024-04-08 20:49:27 +00:00 Compare
Naxdy force-pushed work/superhack-input-mode from 334022ed98 to 36d8c42d50 2024-04-08 20:49:42 +00:00 Compare
chore: clippy concurrency
Some checks failed
Code quality / check (pull_request) Has been cancelled
Details
9881f6cbd7
Naxdy force-pushed work/superhack-input-mode from 9881f6cbd7 to 9052c2f0a0 2024-04-08 20:51:04 +00:00 Compare
Naxdy force-pushed work/superhack-input-mode from 9052c2f0a0 to 24062dbd34 2024-04-08 20:51:11 +00:00 Compare
Naxdy merged commit 702cbe5eb0 into main 2024-04-08 20:53:24 +00:00
Naxdy deleted branch work/superhack-input-mode 2024-04-08 20:53:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
breaking

Breaking change, requires a config revision increment.

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

  
Cherrypick

Upon merge into the main branch, should be cherry-picked into the current stable branch.

  
Compat
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind
Chore
A "developer change" like code improvement, dependency update, etc.

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Security
This is security issue

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Status
Shelved
This PR/issue is shelved until further notice. View the discussions for more info.

No labels
breaking
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Cherrypick
Compat
Breaking
Kind
Bug
Kind
Chore
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Status
Shelved
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: NaxdyOrg/NaxGCC-FW#8
No description provided.
Delete branch "work/superhack-input-mode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?